intelowlproject / IntelOwl

IntelOwl: manage your Threat Intelligence at scale
https://intelowlproject.github.io
GNU Affero General Public License v3.0
3.79k stars 426 forks source link

Polyswarm analyzer closes#1255 #2439

Closed g4ze closed 1 month ago

g4ze commented 2 months ago

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

Checklist

Important Rules

mlodic commented 1 month ago

is this still a draft?

g4ze commented 1 month ago

Facing the same problem I did on domain check and knockpy.

g4ze commented 1 month ago

I think this problem only arises when I'm implementing analysers that use new libraries or packages.

mlodic commented 1 month ago

are you rebuilding the containers after you change the requirements?

g4ze commented 1 month ago

yes I am, I'll redo it and update you again.

g4ze commented 1 month ago

image

{
  "assertions": [
    {
      "engine": "XVirus",
      "asserts": "Benign"
    },
    {
      "engine": "Jiangmin",
      "asserts": "Benign"
    },
    {
      "engine": "Qihoo 360",
      "asserts": "Benign"
    },
    {
      "engine": "SecureAge",
      "asserts": "Benign"
    },
    {
      "engine": "Filseclab",
      "asserts": "Benign"
    },
    {
      "engine": "Alibaba",
      "asserts": "Benign"
    },
    {
      "engine": "Crowdstrike Falcon ML",
      "asserts": "Benign"
    },
    {
      "engine": "Proton",
      "asserts": "Benign"
    },
    {
      "engine": "Electron",
      "asserts": "Benign"
    },
    {
      "engine": "DrWeb",
      "asserts": "Benign"
    },
    {
      "engine": "SecondWrite",
      "asserts": "Benign"
    },
    {
      "engine": "NanoAV",
      "asserts": "Benign"
    },
    {
      "engine": "ClamAV",
      "asserts": "Benign"
    },
    {
      "engine": "Ikarus",
      "asserts": "Benign"
    },
    {
      "engine": "RedDrip APT Scanner - RAS",
      "asserts": "Benign"
    }
  ],
  "positives": 0,
  "total": 15,
  "PolyScore": 0.33460048640798623,
  "sha256": "605bbe9256a3f1abffc8b09d011a25674e4fbd631d0f93694766f21190ae32e4",
  "md5": "7598c0b3c9b830502a1103ccae2fab68",
  "sha1": "091329d524469c468b5b2b1659ffac045b9880a0",
  "extended_type": "ASCII text, with CRLF line terminators",
  "first_seen": "2024-08-07T10:06:00.436896",
  "last_seen": "2024-08-07T10:06:00.436896",
  "permalink": "https://polyswarm.network/scan/results/file/605bbe9256a3f1abffc8b09d011a25674e4fbd631d0f93694766f21190ae32e4/54275927186401150"
}
g4ze commented 1 month ago

lmk the migration sequence for once we are ready. Also i think the previous problem was something related to docker build cache and my ISP. All good now.

mlodic commented 1 month ago

polyswarm -> knock so you can finish this while you are here

gitguardian[bot] commented 1 month ago

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [6639150](https://dashboard.gitguardian.com/workspace/399891/incidents/6639150?occurrence=162575496) | Triggered | Generic Password | ecf9bb9b6a046e48377381f1e828feb923c6103c | frontend/tests/components/auth/Login.test.jsx | [View secret](https://github.com/intelowlproject/IntelOwl/commit/ecf9bb9b6a046e48377381f1e828feb923c6103c#diff-5e31c1265e7ad979f122981896cb037b866119ec2d81d5a8b9d78f04038db975L51) | | [6639150](https://dashboard.gitguardian.com/workspace/399891/incidents/6639150?occurrence=162575497) | Triggered | Generic Password | ecf9bb9b6a046e48377381f1e828feb923c6103c | frontend/tests/components/auth/Login.test.jsx | [View secret](https://github.com/intelowlproject/IntelOwl/commit/ecf9bb9b6a046e48377381f1e828feb923c6103c#diff-5e31c1265e7ad979f122981896cb037b866119ec2d81d5a8b9d78f04038db975R48) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

g4ze commented 1 month ago

i've updated the pr, kindly review. do check the TLP.

g4ze commented 1 month ago

ah my bad! on it!

g4ze commented 1 month ago

image i think the free tier doesnt allow usage of ioc endpoints. hashes seem to be working tho.

mlodic commented 1 month ago

oki, I think you can keep them both and we write in the analyzer description that that specific endpoint is for paid customers only. ty!

g4ze commented 1 month ago

image for hashes

mlodic commented 1 month ago

there is an error in the CI, after that I'll merge it! great work!

g4ze commented 1 month ago

seems gtg @mlodic