for @drosetti : I added a boolean environment variable for the integration with Elastic to avoid to have empty ("None") environment variables. This would have created problems in case the _AWSSECRETS variable was enabled.
More generally, it would also make more sense to have that boolean flag to enable/disable the feature instead of leveraging an URL-based variable. In this way you don't have to configure the URL multiple times in case of changes but you have to configure a more easily understandable boolean flag.
mlodic
commented
2 weeks ago
for @drosetti : I added a boolean environment variable for the integration with Elastic to avoid to have empty ("None") environment variables. This would have created problems in case the _AWSSECRETS variable was enabled.
More generally, it would also make more sense to have that boolean flag to enable/disable the feature instead of leveraging an URL-based variable. In this way you don't have to configure the URL multiple times in case of changes but you have to configure a more easily understandable boolean flag.
I updated the doc too: https://github.com/intelowlproject/docs/commit/ecb7c721158eb26a22ad7d1a50329cc4b154c49d