intelsdi-x / snap-plugin-collector-disk

Collects Linux disk metrics from /proc/diskstats
http://snap-telemetry.io/
Apache License 2.0
4 stars 23 forks source link

per-disk option #12

Closed felipewd closed 7 years ago

felipewd commented 8 years ago

In the metrics collected page, this plugin suggests that the metrics are per-disk.

They're indeed collected per-disk, but snapctl metric list only shows /intel/procfs/disk/*/<metrics>

So I can't collect data from only sda, for instance.

In my case, my machine has all sorts of ram[0-14], loop[0-14] which are all being collected and published.

This sounds like a minor (but important) bug to me, because in my case there's extra processing for something I'll never need and extra space/processing on the publisher side (a influx database in my case).

Talked about it on slack with @IRCody.

So please @intelsdi-x/plugin-maintainers take look and see if this can be fixed. Since I'm collecting in 1s (as suggested), this extra data scales to quite the annoyance when deployed to all my machines.

IRCody commented 8 years ago

Also I think this issue is related to snap#654 @intelsdi-x/snap-maintainers.