intelsdi-x / snap-plugin-collector-disk

Collects Linux disk metrics from /proc/diskstats
http://snap-telemetry.io/
Apache License 2.0
4 stars 23 forks source link

Missing description of collected metrics #14

Closed felipewd closed 8 years ago

felipewd commented 8 years ago

Hi,

There are a few metrics this plugin collects that aren't listed in the collected metrics section of README.

As far a I could see, these are, respectively, the 13th and 14th fields in /proc/diskstats:

https://www.kernel.org/doc/Documentation/ABI/testing/procfs-diskstats

13 - time spent doing I/Os (ms) 14 - weighted time spent doing I/Os (ms).

IRCody commented 8 years ago

cc: @intelsdi-x/plugin-maintainers

IzabellaRaulin commented 8 years ago

@felipewd, thank You for pointing this. Good catch. I prepared PR (#15) which fixes that.