Closed IzabellaRaulin closed 8 years ago
@IzabellaRaulin, the value of metric "/intel/procfs/disk/dm-0/octets_write" is pretty high comparing to other values. Do you mind double check to see if it's right? This is my rough look after I upgrade my system to Mac Sierra. We can sync up more tomorrow.
Let me take another look
@IzabellaRaulin, I'm probably very confused:-). I thought we only send derivatives including the first set of values. No raw data at this time. Raw data is for the future enhancement.
@candysmurf, I do not know whether I correctly understood what is no clear. Maybe I will explain that how it works:
There is only a one metric - pending_ops
which is a gauge type, so this metric is returned as it is. The rest of currently available metrics are a derive type - see README.md
This plugin worked before in that way that is explained above, but after introduction of this line master/disk/disk.go#L212 the first derivatives values are sent as a raw, what broke consistency (https://github.com/intelsdi-x/snap-plugin-collector-disk/issues/22). This pull request fixes that :)
According:
No raw data at this time. Raw data is for the future enhancement.
Yes, that's right.
Thanks @IzabellaRaulin for details. LGTM
Fixes #22
Summary of changes:
pending_ops
metric in separate place (before it was done in "calcDerivatives()" and do not skip this gauge-type metric in the first collectionpending_ops
metric to the metric listHow to verify it:
Testing done: