intelsdi-x / snap-plugin-publisher-influxdb

Publishes Snap metrics to InfluxDB
http://snap-telemetry.io/
Apache License 2.0
8 stars 40 forks source link

Problems with releasing new plugin version #127

Closed ghost closed 7 years ago

ghost commented 7 years ago

After adding the tag for the new plugin version:

git tag -a 22 -m 'snap plugin publisher influxdb v22'
git push origin 22

publishing the release binary is not triggered. cc @nanliu

nanliu commented 7 years ago

@mkuculyma, PR #124 broke travis configuration. The matrix exclusion stopped building go 1.6.x, and it stopped building go 1.7.x releases and 1.7.x large tests:

matrix:
  exclude:
  - go: 1.7.x
    env: SNAP_VERSION=latest TEST_TYPE=large
  - go: 1.7.x
    env: SNAP_VERSION=latest_build TEST_TYPE=large
  - go: 1.7.x
    env: TEST_TYPE=build

We are no longer building new binaries or releasing at this point. We should delete tag 22, fix the matrix and re-release tag 22.

ghost commented 7 years ago

@nanliu thanks! :turtle:

nanliu commented 7 years ago

Hmm, looks like it's building to s3, but the github release is skipped for golang 1.8.x. I'm reopening this.

nanliu commented 7 years ago

Looks like $TRAVIS_GO_VERSION is 1.8 instead of 1.8.0 so the regex for release is buggy. This will require a minor fix.

nanliu commented 7 years ago

version 22 released and verify it built correctly.