search

intelsdi-x / snap-plugin-publisher-kafka

Publishes snap metrics to Apache Kafka
http://snap-telemetry.io/
Apache License 2.0
0 stars 15 forks source link

Solved issue #22 #23

Closed cr2025x1 closed 8 years ago

cr2025x1 commented 8 years ago

https://github.com/intelsdi-x/snap-plugin-publisher-kafka/issues/22

IzabellaRaulin commented 8 years ago

@cr2025x1, is this pull request ready to be reviewed? I do not why the travis tests didn't trigger. Could You push this commit once again?

cr2025x1 commented 8 years ago

Done as requested. TravisCI was notified and tests are underway.

IzabellaRaulin commented 8 years ago

Thanks a lot for triggering Travis - please, revert your change in main.go, that is why travis checks have failed.

IzabellaRaulin commented 8 years ago

For me it looks good. One question - do we really need 5 commits? Would you mind to squash these to one?

cr2025x1 commented 8 years ago

I didn't know that is possible. 😄 Done as requested.

IzabellaRaulin commented 8 years ago

Thanks a lot. LGTM