Flaky test in scheduler/workflow_test.go

intelsdi-x / snap

The open telemetry framework

http://snap-telemetry.io

Apache License 2.0

1.8k stars 295 forks source link

Flaky test in scheduler/workflow_test.go #1363

Open IRCody opened 7 years ago

IRCody commented 7 years ago

/home/travis/gopath/src/github.com/intelsdi-x/snap/scheduler/workflow_test.go Line 421: Expected: '12' Actual: '9' (Should be equal)

This test is flaky.

lmroz commented 7 years ago

The bug is probably caused by canceled top level processor job. They can go in parallel with ~top level~ publisher job (or at least should) which can increase mock's counter and make whole branch fail early without submitting and working on child nodes.

lmroz commented 7 years ago

By the way, please please avoid storing sync.Mutex as a value anywhere. This can easily cause problems when accidentally copied even if now only pointer to struct storing it is used, during some refactoring such thing might change.