search

intelsdi-x / snap

The open telemetry framework
http://snap-telemetry.io
Apache License 2.0
1.8k stars 294 forks source link

`make proto` should compile protocol buffers for every plugin language supported by snap #1492

Open skonefal opened 7 years ago

skonefal commented 7 years ago

Current make proto rebuilds only golang protobufs. Snap supports multiple languages (e.g. C++) and protobufs should be re-created for them too.

IRCody commented 7 years ago

@skonefal: Would they live alongside the current generated files or be deposited somewhere else?

skonefal commented 7 years ago

Maybe directory for each supported language?

Also after some considerations: other languages might require dependencies that are not ubiquitous (like protobuf 3.0.0 libraires for C++) that are not available easily on some systems (e.g. Centos 7), so compiling them by default might be troublesome.

But at least having proto script & make target for other languages would be great.

jcooklin commented 7 years ago

The python lib includes a script for generating the proto here https://github.com/intelsdi-x/snap-plugin-lib-py/blob/master/scripts/run_codegen.py .

On Wed, Feb 1, 2017 at 7:26 AM Szymon Konefal notifications@github.com wrote:

Maybe directory for each supported language?

Also after some considerations: other languages might require dependencies that are not ubiquitous (like protobuf 3.0.0 libraires for C++) that are not available easily on some systems (e.g. Centos 7), so compiling them by default might be troublesome.

But at least having proto script & make target for other languages would be great.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/intelsdi-x/snap/issues/1492#issuecomment-276686720, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0q-DFaQqNYnNvhR4D8KR-vrDGtk9JGks5rYKQqgaJpZM4LuiXw .