intelsdi-x / snap

The open telemetry framework
http://snap-telemetry.io
Apache License 2.0
1.79k stars 297 forks source link

Updated SNAPTEL.md - added mention about separated snap-cli repo #1732

Closed IzabellaRaulin closed 6 years ago

IzabellaRaulin commented 6 years ago

Summary of changes:

@intelsdi-x/snap-maintainers

kjlyon commented 6 years ago

@IzabellaRaulin , in this PR, can you also address this issue:

In the example section of SNAPTEL.md, when unloading the plugins, there are two typos.

IzabellaRaulin commented 6 years ago

@kjlyon, according:

the second publisher needs to be changed to mock-file

Thanks for catching that. I will change it.

mock needs to be changed to mock1

snap-plugin-collector-mock1 has a name mock and version 1 (the version has never changed because the plugin is used in tests together with snap-plugin-collector-mock2 to check version swapping), so the name="mock" in this case is as expected

kjlyon commented 6 years ago

LGTM