intelsdi-x / snap

The open telemetry framework
http://snap-telemetry.io
Apache License 2.0
1.79k stars 297 forks source link

Concurrent map writes in legacy tests #1735

Open IzabellaRaulin opened 6 years ago

IzabellaRaulin commented 6 years ago

From time to time snap legacy tests (go1.8.1 and 1.7.3) fail because of concurrent map writes happen.

Feel free to add under this issue screenshot when you observe it again.

image

ami-GS commented 6 years ago

Hi @IzabellaRaulin

I could reproduce same issue on PR of 1741 The output is in travis CI of here

and sometimes below command could reproduce the issue as well both original and my modified Dockerfile. ./run_tests_with_docker.sh legacy My commit might not affect legacy test...

donzh commented 6 years ago

Hi @ami-GS

I checked the error message you provided. I didn't find any error message which is related with concurrent map writes. It seems that the first error is related with "Can't import ...". Actually I'm a snap beginner. Could you please tell me why do you think your issue is related with "concurrent map writes". Many thanks!

ami-GS commented 6 years ago

Hi @donzh

I checked as well, the log seems changed...strange.... Travis CI retry test? I'm a Travis CI beginner...

Sorry for confusing you, but the log was exactly "concurrent map writes" at first. and "Can't import ..." was also reported different PR. pleas refer different logs