search

intelxed / xed

The X86 Encoder Decoder (XED), is a software library for encoding and decoding X86 (IA32 and Intel64) instructions
https://intelxed.github.io/
Apache License 2.0
1.38k stars 146 forks source link

xed_build_common.py: strip non-digits from GCC version before comparison #315

Closed mcyril closed 3 months ago

mcyril commented 6 months ago

strip non-digits from GCC version before comparison, fixes build with the clang built of llvm-project trunk (clang reports version string with "git" suffix which raises exception in int())

marjevan commented 5 months ago

Hi, Thanks for the contribution.

Please sign off the commit. For more info and guidance: https://github.com/intelxed/xed/blob/main/CONTRIBUTING.md

marjevan commented 5 months ago

Thanks for the contribution. The changes will be available with the next XED external release.

marjevan commented 3 months ago

Migrated this in https://github.com/intelxed/xed/commit/6d87b5481aa53b5ab1fc2b5a5622759c46746bf9