intentionet / netconan

netconan - a Network Configuration Anonymizer
Apache License 2.0
146 stars 12 forks source link

Add option to remove "comments" from configs #134

Open agember opened 4 years ago

agember commented 4 years ago

It would be useful to include a command-line option that removes "comments" from configs. For example, interface descriptions, BGP neighbor descriptions, remarks in ACLs, etc. Developing keyword lists for this is often non-trivial, so the ability to remove them outright, especially since they don't impact network semantics, would be useful.

(Prompted by a discussion with @sfraint and @progwriter on Slack)

tandreadi commented 4 years ago

Hi @agember, I am collaborating with @Elviraant and I am interested in taking over this issue. Contributing to an open-source project is an assignment for "Software Engineering in Practice" offered by the Management Science and Technology department of AUEB. Could you assign me this issue? Thank you, Theodora

agember commented 4 years ago

Hi @tandreadi, You'll need to ask @dhalperi to assign this issue to you, since I do not have administrative access to this repository. Also, you may want to look at the modifications in my fork of the repository, which are a first attempt at solving this problem: https://github.com/colgate-cs-research/netconan/tree/aaron-line-anonymization I am happy to provide additional suggestions/guidance if you're interested; you can also find me (and other folks) on the Batfish Slack workspace: https://join.slack.com/t/batfish-org/shared_invite/enQtMzA0Nzg2OTAzNzQ1LTcyYzY3M2Q0NWUyYTRhYjdlM2IzYzRhZGU1NWFlNGU2MzlhNDY3OTJmMDIyMjQzYmRlNjhkMTRjNWIwNTUwNTQ

tandreadi commented 4 years ago

@agember thank you very much for all the useful information!

Hi @dhalperi, I am interested in taking over and trying to solve this issue. Could you assign it to me?

dhalperi commented 4 years ago

Hi @tandreadi - you are welcome to work on the issue, no need to assign it to you.