intentionet / netconan

netconan - a Network Configuration Anonymizer
Apache License 2.0
146 stars 12 forks source link

Allow for anonymization of in-memory configurations #186

Closed Kircheneer closed 1 year ago

Kircheneer commented 1 year ago

This change is Reviewable

Kircheneer commented 1 year ago

Why? I am building something for which I want to anonymize configurations before I even have them on the disk, as I never want them on the disk un-anonymized.

Kircheneer commented 1 year ago

Thanks for the quick review! I believe I have addressed all your concerns and the CI should pass - I ran pre-commit run --all-files locally and there were no issues.

Let me know if this matched your desired design now.

Kircheneer commented 1 year ago

Reviewed 2 of 3 files at r2, 1 of 1 files at r3, all commit messages. Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Kircheneer and @sfraint)

_tests/unit/test_anonymize_files.py line 9 at r3 (raw file):_

from netconan.anonymize_files import FileAnonymizer, anonymize_files

Do you know how this got added? Wasn't triggered by pre-commit run --all-files for me. Please revert if so.

Fixed!

Kircheneer commented 1 year ago

Fixed CI again now, sorry.