Adding a image prefix like docker:// for singularity

[antoinetran]

Short Description of the issue

When applying an image like alpine, the singularity fails to run because it does not know it is a docker image.

Environment

• Operating System: Linux
• Other related components versions:

Steps to reproduce

Logs, stacktrace, or other symptoms

kubectl -n argo-workflows logs app-lsdsharedfs-template-gnj4q-group-block-1706385343 -c init
FATAL:   While checking container encryption: could not open image /home/username/.interlink/quay.io/argoproj/argoexec:v3.5.4: failed to retrieve path for /home/username/.interlink/quay.io/argoproj/argoexec:v3.5.4: lstat /home/username/.interlink/quay.io: no such file or directory

Summary of proposed changes

Allow to configure Slurm plugin to add, for all image: if it does not start with / (meaning an absolute path to a local image), then add a prefix like docker:// or oras:// or nothing if the prefix configuration is absent.

[antoinetran]

I think this is already implemented through https://github.com/interTwin-eu/interlink-slurm-plugin/blob/main/examples/config/SlurmConfig.yaml#L7C1-L7C18 . Testing it...

[antoinetran]

The test failed. The prefix did nothing.

In fact, the SingularityPrefix is not a prefix added to image. After looking in the code, I can see that:

• this is used as a prefix for container command (https://github.com/interTwin-eu/interlink-slurm-plugin/blob/4e6cd8d934e9b62bdc5092e288c11c8b788b95e3/pkg/slurm/Create.go#L68), executed before the main command
• neither the SingularityPrefix nor the slurm-job.vk.io/singularity-commands seems to be used, these variables are not used anywhere

My proposition is to add a SingularityImagePrefix in the slurm configuration file and use it in the container creation.

[dciangot]

Yeah, I agree. This was overlooked and never used I suspect.