interactions-py / interactions.py

A highly extensible, easy to use, and feature complete bot framework for Discord
https://interactions-py.github.io/interactions.py/
MIT License
833 stars 185 forks source link

[BUG] AuditLogEventType 130, 131, 132 missing #1600

Open LightD31 opened 7 months ago

LightD31 commented 7 months ago

Library Version

5.11.0

Describe the Bug

Class AuditLogEventType received an invalid and unexpected value 130, a new enum item will be created to represent this value. Please update interactions.py or report this issue on GitHub - https://github.com/interactions-py/interactions.py/issues

Steps to Reproduce

130 = Add a sound to the soundboard 131 = Modify a sound in the soundboard 132 = Delete a sound from the soundboard

Expected Results

AuditLogeventType should recognize these

Minimal Reproducible Code

No response

Traceback

No response

Checklist

Additional Information

No response

Bastien1533 commented 7 months ago

I can look into that 🙋‍♂️

Bastien1533 commented 7 months ago

Seems like an undocumented part of the api, I can suggest names for the events to wait the official implémentation. None of the less it is an easy fix.

LightD31 commented 7 months ago

It's because it's undocumented that I made an issue report instead of a PR

Bastien1533 commented 7 months ago

Okay I see, maybe we could use like SOUNDBOARD_CREATE,SOUNDBOARD_EDIT and SOUNDBOARD_DELETE in the meantime.

AstreaTSS commented 7 months ago

If it's undocumented, the usual thing to do is to simply not add anything until it is. We've ran into issues in the past where we named something too early and would have to do a breaking change to rename it.

Bastien1533 commented 7 months ago

Okay, then we hold that issue for now.

asyntx commented 7 months ago

Setting this issue to pending until documentation exists for the new enumerations.