search

interactive-cookbook / tagger-parser

Tagger and parser models used on our recipes corpus (data), handled with pre- and postprocessing scripts for data conversion (data-conversions)
0 stars 3 forks source link

Evaluation Code Missing? #7

Closed TheresaSchmidt closed 2 years ago

TheresaSchmidt commented 2 years ago

The code for the evaluation used to be in read_prediction.py accessed as a fourth mode "eval". Was there a reason we deleted it? Was there a mistake in it? Or did we just move the code to a separate script (would make sense) and forget to upload it? If nobody objects I'll just upload such a separate script.

siyutao commented 2 years ago

I don't think I made any changes and no objections from me about a separate script - that sounds like a good idea! Thanks Theresa!

irisferrazzo commented 2 years ago

How about this, @siyutao @TheresaSchmidt . Do you still need the issue?

TheresaSchmidt commented 2 years ago

@siyutao Is there any reason you haven't merged, yet?

siyutao commented 2 years ago

@siyutao Is there any reason you haven't merged, yet?

No reason! Thanks for the reminder.