search

interactive-matter / HTTPClient

An Arduino HTTP Client
https://interactive-matter.eu/how-to/arduino-http-client-library/
101 stars 33 forks source link

Rework to support different "Client"-types?! #14

Open Apollon77 opened 9 years ago

Apollon77 commented 9 years ago

Hi,

this library is specific for EthernetClient. In another fork someone adopted it to WifiClient and there is a other issue here to support GSMClient. I also need Ethernet für one project and Wifi for another and so I would wish myself more flexibility

So my idea would be to change the design of the class and have the option to set the used "Client" in constructor. Therefor it would be needed to remove the interitance from EthernetClient and replace by a member variable for the used client instance. Is there any real reason why it is interited at the moment?

Would this be something you would be interested in to work on or should I do it as my own fork?

Apollon77 commented 9 years ago

Hey,

I managed to enhance the library by the possibility to provide the Client class to use. You can have a look at here in a branch from my fork: https://github.com/Apollon77/HTTPClient/tree/MultiClient-HTTPClient

What do you think about it?!

Apollon77 commented 8 years ago

see pull request #16