search

interactive-matter / HTTPClient

An Arduino HTTP Client
https://interactive-matter.eu/how-to/arduino-http-client-library/
101 stars 33 forks source link

Arduino 1.0 and library not compatible #4

Closed hex705 closed 12 years ago

hex705 commented 12 years ago

Hi --

First, really like your your work -- especially the light triangles.

It seems that Arduino 1 and this library are incompatible. Are you working on a fix?

interactive-matter commented 12 years ago

Yes, it is scheduled for this week ;)

Am 09.01.2012 um 18:26 schrieb hex705:

Hi --

First, really like your your work -- especially the light triangles.

It seems that Arduino 1 and this library are incompatible. Are you working on a fix?

Reply to this email directly or view it on GitHub: https://github.com/interactive-matter/HTTPClient/issues/4

hex705 commented 12 years ago

Sweet --

It is a great library -- look forward to it.

S

Ryerson--

Steve Daniels New Media Option School of Image Arts Ryerson, University Toronto, ON www.spinningtheweb.org

On 12-01-10 4:20 AM, "Interactive Matter" <reply+i-2772635-497345bb3375ffc727c256ff07ddb9a81dc4a847-1315878@reply.git hub.com> wrote:

Yes, it is scheduled for this week ;)

Interactive Matter, Marcus Nowotny marcus@interactive-matter.eu interactivematter@gmail.com

http://interactive-matter.eu/

Fon +494051903158 Fax +494051903159

Lippmannstr. 18 22769 Hamburg Germany Ust-ID: DE273621569

Am 09.01.2012 um 18:26 schrieb hex705:

Hi --

First, really like your your work -- especially the light triangles.

It seems that Arduino 1 and this library are incompatible. Are you working on a fix?

Reply to this email directly or view it on GitHub: https://github.com/interactive-matter/HTTPClient/issues/4

Reply to this email directly or view it on GitHub: https://github.com/interactive-matter/HTTPClient/issues/4#issuecomment-342 7182

nmanzi commented 12 years ago

Thank you, I have a project I'd love to use this for and I've just upgraded to Arduino 1.0!

interactive-matter commented 12 years ago

ok, good news: it compiles on arduino 1.0 medium good news: it should work bad news: got no time for testing

So perhaps you can try out the new version - if it works fine, if not tell me the problems

thanks for you help

Marcus

nmanzi commented 12 years ago

I'd love to try it out! Can you push it to github for us? :)

interactive-matter commented 12 years ago

oopsala, there was a problem pushing - now fixed note to self: always recheck pushing ;)

hex705 commented 12 years ago

Hi --

I think there is a way to do this properly through github -- but I am not sure of the protocols -- so going to give this a shot...

Finally got some stuff to work (new Pachube API slowed me down).

I am including two zip'd folders. One with some diff files for the library and a push example for pachube. The other with a copy of the library as I am using it in my folder (with the lib changes included).

I don't know how best to offer proposed changes, hope this format is OK. Thanks for taking the time to do the updates.

If agreeable I can provide an example with prowl/growl.

Proposed changes to the library are minor --

h.diff: Changed the prototype of the constructors to match the new functions. Needed to compile.

Cpp.diff: Added a space to the signature of a constructor -- cosmetic only

Key.diff: Added a tab so that is properly highlighted

Best,

steve

Ryerson--

Steve Daniels New Media Option School of Image Arts Ryerson, University Toronto, ON www.spinningtheweb.org

On 12-01-15 5:06 AM, "Interactive Matter" <reply+i-2772635-497345bb3375ffc727c256ff07ddb9a81dc4a847-1315878@reply.git hub.com> wrote:

oopsala, there was a problem pushing - now fixed note to self: always recheck pushing ;)

Reply to this email directly or view it on GitHub: https://github.com/interactive-matter/HTTPClient/issues/4#issuecomment-349 8016

interactive-matter commented 12 years ago

Hi,

you zip file got somehow eaten by github. I think the right way to do it is to fork the library in github and then upload the changes by committing - I will then review and integrate them. Sounds very interesting! Thanks for you contribution.

If everything else fails you can ping me on http://interactive-matter.eu/contact/ to start the good olde email transfer

Marcus

hex705 commented 12 years ago

Ok -- will do that today.

S

Ryerson--

Steve Daniels New Media Option School of Image Arts Ryerson, University Toronto, ON www.spinningtheweb.org

On 12-01-18 3:53 AM, "Interactive Matter" <reply+i-2772635-497345bb3375ffc727c256ff07ddb9a81dc4a847-1315878@reply.git hub.com> wrote:

Hi,

you zip file got somehow eaten by github. I think the right way to do it is to fork the library in github and then upload the changes by committing - I will then review and integrate them. Sounds very interesting! Thanks for you contribution.

If everything else fails you can ping me on http://interactive-matter.eu/contact/ to start the good olde email transfer

Marcus

Reply to this email directly or view it on GitHub: https://github.com/interactive-matter/HTTPClient/issues/4#issuecomment-354 2695

hex705 commented 12 years ago

OK, forked, changed and committed at -- https://github.com/hex705/HTTPClient -- I assume that you get notified -- but, just in case

interactive-matter commented 12 years ago

I see it. I also see the commits. I will integrate it later - alternatively you can create a pull request in the github web interface. But that is not neccessary. Once I have done so I will close this issue

Many thanks for you help, patience and contribution

Marcus

hex705 commented 12 years ago

OK cool - I am new to github (and repositories) so please forgive my confusion on how to get the info to you -- any many thanks for effort and patience-- and most importantly for a great library. Next time I will get the steps right!

steve

interactive-matter commented 12 years ago

No problem, you did a marvelous job and made things very easy for me - so I have to thank ;)

Marcus

interactive-matter commented 12 years ago

OK, integrated & pushed - will now close this issue, thanks for you help