search

interactive-pioneers / generator-pioneerapp

Yeoman generator to scaffold front-end web app.
GNU General Public License v3.0
3 stars 0 forks source link

Fix linting errors #38

Closed davleh closed 7 years ago

davleh commented 7 years ago

This is a fix for #35

davleh commented 7 years ago

Yes, but this file is not part of the repository. We could add a linter exception, but then tests would not get linted anymore. I would perhaps fix the generator-mocha to meet our conventions?

ain commented 7 years ago
  1. It's not about Mocha at all
  2. JSHint sure already follows the convention

  3. All that I meant by meta information were comments in file header for JSHint, e.g. 

    
/* global expect */
ain commented 7 years ago

@beroes could you take this one over from David?

beroes commented 7 years ago

@ain I have no idea how to solve this issue.

ain commented 7 years ago

@davleh you were right, sorry. It's generator-mocha code this test.js.

davleh commented 7 years ago

So this is mergeable now, right? @ain