interactive-pioneers / generator-pioneerapp

Yeoman generator to scaffold front-end web app.
GNU General Public License v3.0
3 stars 0 forks source link

JavaScript coding conventions check fails out of the box #47

Open ain opened 7 years ago

ain commented 7 years ago

Steps to reproduce:

  1. Scaffold project with

    $ yo pioneerapp test
  2. Run QA tools

    $ grunt qa

What happens:

    Running "jscs:src" (jscs) task
    disallowTrailingWhitespace: Illegal trailing whitespace at Gruntfile.js :
       315 |        helpers: ['handlebars-helper-i18n', 'handlebars-helper-rawinclude']
       316 |      },
       317 |      
    --------^
       318 |      index: {
       319 |        options: {
    disallowTrailingWhitespace: Illegal trailing whitespace at Gruntfile.js :
       375 |        'jshint',
       376 |        'jscs',
       377 |        
    --------^
       378 |        //'mocha',
       379 |        'pngcheck'
    >> 2 code style errors found!
    Warning: Task "jscs:src" failed. Use --force to continue.

What should happen: No JSCS validation errors should be there on first run, out of the box.

ain commented 7 years ago

Addressed in #48.