search

interactive-pioneers / iptools-jquery-offcanvas

Simple CSS3 animated offcanvas.
GNU General Public License v3.0
2 stars 5 forks source link

Inconsistent event naming #1

Closed davleh closed 8 years ago

davleh commented 8 years ago

Open event is called 'opened' when triggered and 'open' within destroy method. I would suggest to rename the triggered event into 'open' to have it consistent with 'close'. A 'opened' or 'closed' event could be triggered additionally when the animation has completed.

davleh commented 8 years ago

Ok, as discussed, only a closed event has to be added, everything else is perfect. :)

GeorgMeyer23 commented 8 years ago

9fc51fb