search

interagent / committee

A collection of Rack middleware to support JSON Schema.
MIT License
883 stars 135 forks source link

(HyperSchema) Refactoring Response Validation to Enhance Consistency #422

Open chibicco opened 6 months ago

chibicco commented 6 months ago

Overview

I am considering moving the status_code=204 && empty response check to the SchemaValidator::HyperSchema::ResponseValidator to maintain consistency with the following PR.

ref: https://github.com/interagent/committee/pull/417/files#r1597413928

I plan to create a PR myself, but I would appreciate it if you could let me know if there are any other potential solutions.

ydah commented 6 months ago

There are no other ideas at this time, so you can work on this when you want to.

chibicco commented 6 months ago

I'm sorry, but I've been busy with my main job and haven't been able to respond m( )m I plan to create the PR within June.

I apologize for any inconvenience and appreciate your understanding.

ydah commented 6 months ago

@chibicco You don't have to apologize😀 Because this is an OSS project, not a job. Please work on it when you want to. Don't worry about the pace of work 👍🏻

chibicco commented 1 month ago

Hi, As we project has transitioned to OpenAPI 3.0, I no longer have opportunities to utilize the 2.0 logic. I will be deferring any revisions regarding this matter 🙇

geemus commented 1 month ago

@chibicco thanks for letting us know.