interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
802 stars 73 forks source link

RFC: Add app_name and source to default config #233

Closed gudmundur closed 8 years ago

gudmundur commented 8 years ago

For most pliny apps I've created, I've added Config.app_name and Config.source to track the app and environment. This is useful for setting up a default log context and measuring values.

With those two config values, we can add them as defaults to config/initializers/log.rb.

pedro commented 8 years ago

+1 for app! We can infer from pliny-new and set that for new pliny apps. What is source, the process name?

gudmundur commented 8 years ago

@pedro source is the stage it's running in, i.e. development, staging or production.

pedro commented 8 years ago

ooo Pliny already has it – we call it deployment (though it needs better documentation as everything else)

danp commented 8 years ago

Closed by https://github.com/interagent/pliny/pull/240 and https://github.com/interagent/pliny/pull/243?

brandur commented 8 years ago

@dpiddy Good call! Thank-you :)

gudmundur commented 8 years ago

Thanks, I had forgotten about this issue.