search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
802 stars 73 forks source link

update PRMD dependency #248

Closed heavysixer closed 8 years ago

heavysixer commented 8 years ago

Would it be possible to have the Pliny gem use a more current version of PRMD? Right now we are bound to 7, but PRMD is at 11+ now.

selectport commented 8 years ago

FWIW, in a modified fork, i simply bumped the gemspec dependency to :

spec.add_dependency "prmd", "~> 0.11", ">= 0.11.4"

and while far from exhaustive in my new project, i've not hit any issues with that version of prmd yet.

gudmundur commented 8 years ago

Yeah, excellent point. Would you mind opening up a PR for it? I'll get it reviewed and merged in the next couple of days.

@geemus Any objections?

selectport commented 8 years ago

Not sure if that was for me or @heavysixer, but since i had it available - PR submitted.

heavysixer commented 8 years ago

Thanks @selectport and @gudmundur !

geemus commented 8 years ago

Definitely, will merge now.

gudmundur commented 8 years ago

Thanks for reporting @heavysixer and thanks for submitting a PR @selectport!

heavysixer commented 8 years ago

Awesome, do you know when this will be pushed to a release of Pliny? I am wondering when I can use it in the wild.

gudmundur commented 8 years ago

@heavysixer woops, we missed releasing the gem. I've released 0.15.1 now.