search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
802 stars 73 forks source link

Rollbar and RescueErrors revamp #265

Closed gudmundur closed 8 years ago

gudmundur commented 8 years ago

In a comment on #264 I described a solution for handling exceptions raised within a request. When I looked into the Heroku API, it turns out that's exactly the approach I was considering. Much of this code is lifted from there, and is the work of @brandur.

This stops using the Rollbar middleware, and instead explicitly reports unexpected errors to Rollbar.

gudmundur commented 8 years ago

@brandur nudge nudge

brandur commented 8 years ago

@gudmundur Hey, sorry about the delay! This looks good to me. Nice work :) Ship it!