interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
801 stars 73 forks source link

Add "rollbar.person_data" to rollbar scope #323

Closed ransombriggs closed 6 years ago

ransombriggs commented 6 years ago

I was attempting to add the logged in user to my rollbar reports and setting the rack env data did not work. It did when I used the default reporter and tracked the difference down to here https://github.com/rollbar/rollbar-gem/blob/master/lib/rollbar/middleware/rack.rb#L33 . This just duplicates that functionality in the pliny reporter. The test is a little clunky in that it tests some rollbar functionality, but I wanted to make sure that the person data is picked up correctly.

ransombriggs commented 6 years ago

@mikehale extracted the logic from our app, does this look good?

mikehale commented 6 years ago

👍

gudmundur commented 6 years ago

LGTM