search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
802 stars 73 forks source link

Sort by filename when generating INSERTs #324

Closed fdr closed 6 years ago

fdr commented 6 years ago

Previously, the only thing keeping the output of .sql generation was the insert order of tuples happening to the recall order...something that can easily de-synchronize with multiple developers that may be writing migrations at the same time.

Instead of getting the tuples in any order, sort them by their content.

pedro commented 6 years ago

:+1:!!!

brandur commented 6 years ago

LGTM.

(Unfortunately, with Gudmundur departing Heroku, and presumably his Pliny projects, we may not have a dedicated release manager anymore. Do you want to see if you can cut one?)

gudmundur commented 6 years ago

@brandur I don't mind cutting a release now and possibly a few more in the future. But it would be nice to promote someone at Heroku to take over that role.