search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
801 stars 73 forks source link

Use the current ruby version when generating a new project #327

Closed dmathieu closed 5 years ago

brandur commented 6 years ago

Seems like an improvement! It does have a slight disadvantage in that if the local creator's Ruby version is outdated, then the new Pliny project will also be created on that outdated version of Ruby.

dmathieu commented 6 years ago

It does have that disadvantage, yet. For the record, rails does the same thimg.

brandur commented 6 years ago

For the record, rails does the same thimg.

Ah, fair enough.

gudmundur commented 6 years ago

Seems like an improvement! It does have a slight disadvantage in that if the local creator's Ruby version is outdated, then the new Pliny project will also be created on that outdated version of Ruby.

I'm assuming this can be checked in code before generating? I.e. if Ruby version is older than what we require, warn or err?

dmathieu commented 6 years ago

Which version would we use as the oldest one? When would that be upgraded. I just opened this because the previous default was 2.4.0, and manually upgrading it every years seems weird.

gudmundur commented 6 years ago

@dmathieu 2.4.0 sounds about right.

dmathieu commented 6 years ago

I've updated the PR to do just that.

dmathieu commented 5 years ago

Sorry, I didn't see the tests were failing. I've fixed them, the last failing one seems to be an unrelated issue.