search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
801 stars 73 forks source link

Support for Sinatra 2.1 #336

Closed beanieboi closed 3 years ago

beanieboi commented 4 years ago

Sinatra 2.1 changed how helpers are loaded. They switched from include to prepend https://github.com/sinatra/sinatra/commit/2db247dd33bb29732a8e1d7e3a2172ee9e153efb

Going forward we need to depend on Sinatra 2.1 or higher.

bensymonds commented 3 years ago

I looked into this a bit and opened #337 as an alternative. My preference is for #337 because, even though as a breaking change it's more effort, it's the long-term (and "correct", I think) fix. But I may be underestimating the impact of the breaking change.