search

interagent / pliny

An opinionated toolkit for writing excellent APIs in Ruby.
MIT License
801 stars 73 forks source link

update supported rubies #355

Closed beanieboi closed 11 months ago

beanieboi commented 11 months ago

drop support for ruby 2.5, 2.6 and 2.7 add support for ruby 3.1 and 3.2

edmorley commented 6 months ago

@beanieboi Hi! Should gem.required_ruby_version be set in pliny.gemspec too, to ensure newer pliny versions aren't incorrectly installed when using older Ruby?

Since Dependabot just opened a PR updating Cheverny to newer pliny, but CI still passed even though it's using Ruby 2.7 which is no longer tested in CI on pliny's side.

beanieboi commented 6 months ago

@beanieboi Hi! Should gem.required_ruby_version be set in pliny.gemspec too, to ensure newer pliny versions aren't incorrectly installed when using older Ruby?

Since Dependabot just opened a PR updating Cheverny to newer pliny, but CI still passed even though it's using Ruby 2.7 which is no longer tested in CI on pliny's side.

Yeah that's a good idea. I opened https://github.com/interagent/pliny/pull/365 for it