search

interbred-monkey / id3_reader

A Node.js ID3 Tag reader
15 stars 6 forks source link

Comment(s) and year not written #11

Open vonbearshark opened 8 years ago

vonbearshark commented 8 years ago

My comment and year fields aren't written. Rather, they are not being read by any other ID3 readers. Both do show up when reading from this reader (although the year is truncated to 2 digits, for some reason). Still, they do not show up in any other reader I've tried.

var params = {
    //..
    tags: {
    title: 'title',
    artist: 'artist',
    //..
    year: '1999',
    comments: 'MY_COMMENT' //I've tried it with "comment", as well
   }
};
id3.write(params);

I get the same results from buffer or from a path to a file.

FTW, I'm actually doing this manipulation in the browser by converting a File/Blob to a psuedo-Buffer (https://github.com/feross/buffer). But I'm also testing this with Node with the same results.

vonbearshark commented 8 years ago

@interbred-monkey if you can figure out what might be wrong, I can try and look into it myself.

interbred-monkey commented 8 years ago

I'm not totally sure at the moment, there is a couple of things that are being dropped and truncated at the moment. I also have a weird tag that is being appended. I think the way I am generating the tags is wrong so I am looking into rewriting this completely.

vonbearshark commented 8 years ago

It's interesting that some things are dropped, and others are written perfectly fine. It's also a little weird that this library can read tags it writes, but others can't. It suggests that some tags have a different convention for writing, I think. Would you have any reason to believe, say, COMM has different specs for writing? I can try and help out if you have some idea of what needs to be done.