search

intercaetera / golden

An Android Netrunner tournament hosting software.
GNU Lesser General Public License v3.0
14 stars 4 forks source link

SoS calculation bug? #13

Closed gereons closed 7 years ago

gereons commented 7 years ago

I just ran a dummy tournament, where some SoS entries do not show the values I'm expecting.

bildschirmfoto 2017-04-02 um 15 20 23 bildschirmfoto 2017-04-02 um 15 20 32

Player F has played K and f. K has an average score of 1.5, f has 4. This should result in an SoS value of 2.75 (5.5 / 2.0), and thus in Player F being ranked first instead of second.

BTW, as eSoS is the second tiebreaker, I would suggest that it's also displayed in the rankings table.

intercaetera commented 7 years ago

Could you post the cjson file of the tournament here? This requires investigation.

gereons commented 7 years ago

Sure: Test_Pairings-r2.cjson.zip

intercaetera commented 7 years ago

The SOS is calculated correctly however it seems to be updated at odd times. This is fortunately much less of a severe issue than I first thought. A fix is coming shortly.

intercaetera commented 7 years ago

From now on the SOS is calculated before pairing up each round and upon refreshing the players view (just in case) rather than when scoring a match.