search

intercellular / cell

A self-driving web app framework
https://www.celljs.org
MIT License
1.5k stars 94 forks source link

'Github' typo in README.md (all branches) #117

Closed 0joshuaolson1 closed 7 years ago

0joshuaolson1 commented 7 years ago

-> GitHub

gliechtenstein commented 7 years ago

Thanks for reporting! Please feel free to send a pull request, any contribution is welcome! :)

gliechtenstein commented 7 years ago

https://github.com/intercellular/cell/commit/41faf5e03eb42fceb4e99a7802fb80985daa6b62

gliechtenstein commented 7 years ago

For future reference, editing the README (or any other file) is as easy as going to the edit view https://github.com/intercellular/cell/edit/develop/README.md (in case of readme), updating, and sending a pull request.

Don't worry about messing up, since pull requests need to be merged in anyway :)

0joshuaolson1 commented 7 years ago

I would've, but there's still the plan and gh-pages branches. Can you use 1 PR to patch both?

gliechtenstein commented 7 years ago

I just merged them all so they're reflected there as well :) You can see here:

https://github.com/intercellular/cell/tree/master

https://github.com/intercellular/cell/tree/gh-pages

You don't have to worry about master and gh-pages branch, when sending a PR, just need to fix develop and it will eventually be merged into master and gh-pages, hope this makes sense!

piranna commented 7 years ago

Is gh-pages branch pick from master? If it's so, then you can go to project settings and set master branch to generate the Github page site, and also configure to only generate it from the docs folders... There's no need to have master duplicated on gh-pages branch.

gliechtenstein commented 7 years ago

@piranna yeah currently the website is not generated from a static site generator but I generate it dynamically using an in-house library I wrote. I've been meaning to take care of this at some point but just kept it this way till now. Will think about this and take care of it soon. Thanks for the tip!