Closed devsnek closed 7 years ago
Thank you so much for the PR!
I totally agree that consistency is important, and I have no problem with semicolons (I was writing a lot of node code when I started working on cell so the habit just transferred to cell's codebase but I actually think having semicolons is for the better when it comes to frontend context. Not the biggest fan of single quotes but I can live with that haha.
Anyway I'm totally for adding lint (and probably adding some CI automation so the lint automatically kicks in for each commit attempt)
Btw I think I got something out of sync while merging the previous PRs (was coming up from the older ones). Now this one says there are conflicts that must be resolved. I was looking at the "conflicts" but not sure why they're detected as conflicts instead of just updates. Can you try synchronizing and re-pushing? Or if you know what I did wrong please let me know. Thanks!
sure thing, i can also setup travis to run mocha/eslint (and even auto-minify and push to a "release" branch or smth if the tests pass)
Wow that would be more than awesome!
And thanks for taking care of the sync, merged! :)
Obviously an ESLINT is opinionated, so I would encourage anyone who disagrees with a rule to provide a good case for their opinion so we can come to the best agreement that suits the development of this lib.
Notable Things That Might Annoy People (NTMAP):