Open Tirpitz93 opened 6 years ago
Using PEP8 would be a good start ;). I'd suggest doing as "everyone else does" and increasing the line size limit to 120 chars (with 1080p and even 4k monitors nowadays)
I'm sitting on a fence regarding the camelCase vs snake_notation. I'm used to snake but I also see the benefit of sticking to the original SQF function names. Deep inside me I'd prefer to stick with the original naming (less confusion) but I haven't done enough Arma modding (nor even used Intercept much) to speak authoritatively about this matter.
Where do you guys stand on replacing get_*
and set_*
with a property?
If necessary adding aliases to the property.
Also what would the preferred naming convention/ namespace for the class names be?
RV_*
Intercept_*
Arma_*
I have some boilerplate code here: https://github.com/Tirpitz93/intercept-python/tree/python_classes.
Intercept uses snake_case
for all SQF wrappers as well, might as well do the same here.
Which coding standards/PEP guides are you planning to adhere to. As this is a python library aimed at python users(presumably) the PEPs would be a good place to start.
Also when implementing the classes there are a couple options regarding the OOP interface as I see it:
getPos player
becomesplayer.getPos()
. orplayer.get_pos()
@property
decorator to wrap the calls to the DLL to the user so thatgetPos player
becomesplayer.pos
, andplayer setPos [a,b,c]
becomesplayer.pos = [a,b,c]
.