search

interchange / TableEditor

25 stars 4 forks source link

DB confguration from interface #34

Open sime-k opened 9 years ago

sime-k commented 9 years ago

Write DB conf from interface into enviroment YAML file instead of additional SQLite conf file.

racke commented 9 years ago

What is the benefit of this?

sime-k commented 9 years ago
  1. All in one place.
  2. You border the difference between interface configuration and editing conf file. Now if you use interface it generates SQLite fie but if you want to do it manally you do it in YAML conf file.
racke commented 9 years ago

How do you prevent conflicts between manipulating YAML file from the app and from the user if that is the same file?

primozjeras commented 9 years ago

How do you prevent conflicts between manipulating YAML file from the app and from the user if that is the same file?

how do others solve it? i agree woth sime that it is weird to keep same configuration in 2 places. we add confusion and complexity at very early stages of product.

racke commented 9 years ago

In my opinion, you shouldn't mess with configuration files from inside your app. This extra configuration goes into a database - as we did.

sime-k commented 9 years ago

I was thinking SQLlite is anyway generated once the TE is started and it can only be edited trough file, so we add the database options in environments conf so people can find it.

sime-k commented 9 years ago

Anyway once you are installing the TE there is no environments folder so app isn't messing with your file, since you do't have it.

yure commented 9 years ago

grega, you are kind of running this thing, what do you think?

On 30. 10. 2014 11:06, Šimun Kodžoman wrote:

I was thinking SQLlite is anyway generated once the TE is started and it can only be edited trough file, so we add the database options in environments conf so people can find it.

— Reply to this email directly or view it on GitHub https://github.com/interchange/TableEditor/issues/34#issuecomment-61069099.

Jure Kodzoman

Informa Studio d.o.o. - Internet Marketing Company Zadobrovška cesta 75 SI-1000 Ljubljana, Slovenia +386 1 88 88 567 http://www.informastudio.com

This email is UNCLASSIFIED.

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. Please note that any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company.

racke commented 9 years ago

SQlite is generated if it doesn't exist, yes.

sime-k commented 9 years ago

environments/development.yml with db options also doesn't exist.

racke commented 9 years ago

@sime-k - there is certainly a usecase for having environments file. Or should everyone go into TE with standard passwords?

gregapompe commented 9 years ago

Yes it is.

I generally agree that 2 files just add unnecessary complexity and confusion, so it would be better to have it in one. On the other side I also don't like if someone is messing with my config file.

But here we actually don't have a env/dev file yet and is just created. I think we should put it there and never edit it through GUI. If the file already exists and there is a db information in it than TE will just take that and won't even ask user for it.

So the only bad scenario is situation where there is a dev file without db info in it. But i think that goes in advanced users section and can be solved with simple warning.