interchange / interchange6-schema

DBIC schema for Interchange 6
8 stars 7 forks source link

redundant fields in Order class #157

Closed hexfusion closed 2 years ago

hexfusion commented 9 years ago

We have multiple fields in Order that are redundant due to other classes. I think these should be removed as they can promote underutilization of existing classes, stale data and confusion.

payment_method, payment_number and payment_status. This data should be properly stored in PaymentOrder class.

shipping_method we have a whole series of shipment classes.

Data storage imo should be standardized. Allowing "simple" alternative methods for storage will only hurt a cart in regards to long term scalability and data accuracy. I guess I am looking for a reason why these should stay.

racke commented 9 years ago

Can you please add the redundant fields?

hexfusion commented 9 years ago

payment_status, payment_method, and payment_number all can have multiple values for a single order. So defining them with a single field imo is wrong.

hexfusion commented 9 years ago
14:51:03  hexfusion ╡ SysPete should we support multiple payments on a single order as far as schema goes                                                       │
14:51:20          ⤷ ╡ in some cases this might be required                                                                                                      │
14:51:23          ⤷ ╡ ie                                                                                                                                        │
14:51:54          ⤷ ╡ order is placed online customer calls and wants to add another item                                                                       │
14:52:10          ⤷ ╡ or                                                                                                                                        │
14:52:42          ⤷ ╡ in the case of return would a payment be negative value?                                                                                  │
14:52:58    SysPete ╡ also part-payments                                                                                                                        │
14:53:18          ⤷ ╡ deposits                                                                                                                                  │
14:53:49  hexfusion ╡ if either is possible then we should look at removing payment_status, and payment_number for Order                                        │
14:54:06          ⤷ ╡ and payment_method                                                                                                                        │
14:54:09    SysPete ╡ accommodation is typical example 
hexfusion commented 9 years ago

@SysPete I think methods to return these values might be more useful then these actual fields.