search

intercity / chef-repo

Set up your server to host Ruby on Rails apps. - Follow us on Twitter: @intercityup
MIT License
417 stars 84 forks source link

Added SSL certificates uploading. #164

Open ghost opened 9 years ago

ghost commented 9 years ago

As per #139 I removed the old approach of adding certificates as strings to node JSON file. Cookbook files are used instead.

ghost commented 9 years ago

@berkes could you please take a look at #164? Thanks

berkes commented 9 years ago

:+1:

We might need to deal with upgrades though. We don't want people who upgrade and have a config with the contents of the ssl-files (as was in the old situation) to suddenly break all their SSL on production (which won't really happen now, because you already raise an exception if the file is not found)

Either we make the option a little smarter and have it detect if it is a path to a file or the content of a cert.

Or we simply document and communicate this very well (as you already do with the raise).

jvanbaarsen commented 9 years ago

What about we first go in a deprecation mode of the old way? So for this release we support both, and throw a big fat warning if people use the older version. And in the next release we remove the old way all together?

berkes commented 8 years ago

I'd still really love this feature to be in. The hardest part is to make it backwards compatible though.

@jvanbaarsen @michiels how about a 3.x version that contains all such larger changes. We'd then not have to introduce all sorts of complexity to support many ways to do a thing (old, new etc) but rather One Way: the new way.

jvanbaarsen commented 8 years ago

@berkes I have to take a good look at this PR, and also see how we can incorporate this in https://github.com/intercity/intercity (The main product we created this for). I think I can free some time for this next friday (I've put it on my todo list for that day)