search

intercity / chef-repo

Set up your server to host Ruby on Rails apps. - Follow us on Twitter: @intercityup
MIT License
417 stars 84 forks source link

Sets encoding to utf-8 for sysadmins metadata file #178

Closed joshuajansen closed 9 years ago

joshuajansen commented 9 years ago

Installing my local Vagrant box threw the following error:

ERROR: /home/vagrant/chef-solo/cookbooks-2/sysadmins/metadata.rb:2: invalid multibyte char (US-ASCII)

I was able to solve this by setting the encoding explicitly to utf-8 for the metadata.rb file so that @berkes's name would be handled properly.

jvanbaarsen commented 9 years ago

@berkes Did you hear of this before?

jvanbaarsen commented 9 years ago

@joshuajansen Can you also make an entry in the Changelog?

joshuajansen commented 9 years ago

@jvanbaarsen did I do this properly? https://github.com/intercity/chef-repo/commit/e2b553fda458ab1e6d6e369b3fbdec42d6fba2df

jvanbaarsen commented 9 years ago

@joshuajansen Yep! Thanks :cake:

berkes commented 9 years ago

I've heard of this quote often. And thought i'd set the byteordermark BOM correct on my files. Could be that I forgot it.

Though not all platforms and older ruby versions adhere to that. In those cases you'd need to add a magic comment to the beginning of files.

berk.es - Open Source Web development - Ruby development

Sent from my phone.

Jeroen van Baarsen notifications@github.comschreef:

@berkesDidyouhearofthisbefore?ReplytothisemaildirectlyorviewitonGitHub.

michiels commented 9 years ago

What version of Ruby was this by the way?

— Verzonden via Mailbox

On Tue, Feb 24, 2015 at 7:53 PM, Bèr Kessels notifications@github.com wrote:

I've heard of this quote often. And thought i'd set the byteordermark BOM correct on my files. Could be that I forgot it.

Though not all platforms and older ruby versions adhere to that. In those cases you'd need to add a magic comment to the beginning of files.

berk.es - Open Source Web development - Ruby development Sent from my phone. Jeroen van Baarsen notifications@github.comschreef:

@berkesDidyouhearofthisbefore?ReplytothisemaildirectlyorviewitonGitHub.

Reply to this email directly or view it on GitHub: https://github.com/intercity/chef-repo/pull/178#issuecomment-75820505