search

intercity / chef-repo

Set up your server to host Ruby on Rails apps. - Follow us on Twitter: @intercityup
MIT License
417 stars 84 forks source link

Fix Ruby 2.2.0 build errors #197

Closed michiels closed 9 years ago

michiels commented 9 years ago

This PR fixes the Ruby 2.2.0 FFI build errors by adding a default package dependency of "libffi-dev" to the Rails setup recipes.

See for reference: https://github.com/sstephenson/ruby-build/issues/690

and https://github.com/sstephenson/ruby-build/wiki#build-failure-of-fiddle-with-ruby-220

jvanbaarsen commented 9 years ago

@michiels What is different in this patch compared to: https://github.com/intercity/chef-repo/pull/186/files?

michiels commented 9 years ago

Ah! I'm sorry, I didn't see that one.

The only difference would be that I put it in the rails::setup recipe that contains all the shared setup for both the Unicorn as Passenger stack. I prefer keeping that setup for the shared things. Do you agree?

jvanbaarsen commented 9 years ago

@michiels Ok, but then this patch would be about moving that line right? So it needs to be removed from the other files.

michiels commented 9 years ago

Correct. I will add it.

michiels commented 9 years ago

Done. Rebase & merge?

jvanbaarsen commented 9 years ago

@michiels Yes :)

michiels commented 9 years ago

I hit the same problem with the test-kitchen LIBRARIAN_COOKBOOKS setting that was wrong. So I just wasted 3 hours to figure out that libffi was already in there ;) So see this PR as an unintentional refactoring.

jvanbaarsen commented 9 years ago

:dancer:

michiels commented 9 years ago

This should be it.