Create/destroy deploy keys and install SSL certificate using sudo

intercity / intercity-next

Web control panel to deploy apps on your servers (with Dokku)

https://intercity.io/

MIT License

116 stars 23 forks source link

Create/destroy deploy keys and install SSL certificate using sudo #226

Closed joshuajansen closed 5 years ago

joshuajansen commented 7 years ago

I've ran into an issue where deploy keys weren't added on a server that's set up with passwordless sudo.

This was because the intercity user can't write to dokku's authorized_keys. This can be resolved by executing this command with sudo: https://github.com/intercity/intercity-next/blob/e9225eb1ba5c0e0f412ca5a27da29143fc72d864/app/jobs/create_deploy_key_job.rb#L6

joshuajansen commented 7 years ago

It seems that adding SSL certificates has the same issue.

michiels commented 5 years ago

I think that this bug is solved for the deploy keys as we now add them via sudo. But it's still around for the custom SSL certificate. I'll rename this issue's title and add it to the current project focus.

michiels commented 5 years ago

PR is up to fix this