search

intercity / intercity-next

Web control panel to deploy apps on your servers (with Dokku)
https://intercity.io/
MIT License
116 stars 23 forks source link

Update Ruby to 2.5.1 #241

Closed ariejan closed 6 years ago

ariejan commented 6 years ago

Just to keep things running smoothly. :-)

jvanbaarsen commented 6 years ago

Seems like a good idea! Before we merge this in, We also need to update this repo: https://github.com/intercity/intercity-docker/blob/master/images/base/Dockerfile to use the latest ruby version.

I can do that somewhere later this week. If you want you can also go ahead and make a PR there, would be highly appreciated :D

ariejan commented 6 years ago

I'll have a look if I get around to it. Doing this during breaks and lunch ;-) For now my focus is on getting a docker-compose setup correctly.

jvanbaarsen commented 6 years ago

@ariejan If we can get that going we can even drop that other repo all together, which would be super nice.

ariejan commented 6 years ago

FYI: I had to downgrade back to 2.4.2 because of Net::SSH issues with 2.5.1.

jvanbaarsen commented 6 years ago

@ariejan Would it make sense to close this PR in that case?

ariejan commented 6 years ago

@jvanbaarsen yes.