search

intercity / intercity-next

Web control panel to deploy apps on your servers (with Dokku)
https://intercity.io/
MIT License
116 stars 23 forks source link

Don't apply ENV var changes right away and offer restart option #254

Closed michiels closed 5 years ago

michiels commented 5 years ago

This PR attempts to solve #247 by disabling the direct application of ENV vars by default. Instead a checkbox is presented where the user can enable applying an ENV var right away:

schermafbeelding 2018-11-19 om 23 40 13

As described in issue #247 - this would prevent Dokku from restarting the app multiple times if ENV vars are added shortly after each other. This results in dangling containers on the host because Dokku is not able to properly clean up old containers if multiple restarts run in parallel.

To allow for applying ENV var changes after they are added a widget is added to this page to restart the app. This way someone can make modifications to their ENV var setup (eg dokku config <app>) and then restart the app on a moment that it makes sense:

schermafbeelding 2018-11-19 om 23 42 18

michiels commented 5 years ago

@joshuajansen Yeah exactly! Was thinking the same. So you can show something like "You have pending ENV var changes, apply now"