search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

assigned_to deserialize #101

Closed RafaelCavazza closed 6 years ago

RafaelCavazza commented 6 years ago

Why the 'assigned_to' attribute in the ConversationPart class is a string in the bv/netstandard2.0 branch?

It shouldn't be 'Assignee'?

image

image

When I tried to run the netstandard2.0 branch i've got the folowing erro: Newtonsoft.Json.JsonReaderException : Unexpected character encountered while parsing value: {. Path '[0].assigned_to', line 10, position 20.

Then i verified that the 'assigned_to' attribute is a object. When I changed it from string to Assignee it worked.

kmossco commented 6 years ago

Hey @RafaelCavazza! Thank you so much for reporting this, seems like this is wrong indeed. I tested this based on the conversation part model in our API reference here:

image

But I think my testing may have been wrong. I'll look into this and make a change this week. Let me know if you find any other problems, and thank you for testing this!

kmossco commented 6 years ago

This is now fixed here: https://github.com/intercom/intercom-dotnet/pull/97/files#diff-aa05218441e91c417e15908edaec2380R17. And will update the documentation so the API reference reflects what is returned. 👍 Thanks once again!

RafaelCavazza commented 6 years ago

Hi @kmossco!

Thanks for the response!

We are developing a integration using the bv/netstandard2.0 branch. We are migrating to the Net Core envioroment and will be using some of the API functionality.

I'll report any bug, issue or improvement we find.

We hope to see soon the .netStandard2.0 package in your nuget.

Best Regards!

kmossco commented 6 years ago

Glad to hear it! 🎉We are currently working on getting it peer reviewed to ensure we don't break anyone's workflow, and hopefully we will have a release very soon!

And if you spot anything missing, a bug or have any feedback we are all 👂s!