search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

Doesn't work with the last version of RestSharp #102

Closed ogamaniuk closed 6 years ago

ogamaniuk commented 6 years ago

It seems like the library doesn't work with RestSharp 106.0.1. Why don't you remove the dependency on RestSharp at all?

kmossco commented 6 years ago

Hey there! We currently have a PR open for review that moves the library to .NET Standard 2.0 and works with the latest version of RestSharp. Maybe you can give that a try? PR: https://github.com/intercom/intercom-dotnet/pull/97 More info on why we didn't remove this dependency is also in that PR comment.

However at the moment the current version of the library can't support the new version of RestSharp and we won't be working to add support to it, and will move on with the work on that PR.

dkarger commented 6 years ago

Hi @kmossco i've hit this restsharp issue too. When you're ready to merge in the PR in and create a pre-release nuget package i'd be happy to test out.

kmossco commented 6 years ago

Hey @dkarger! We hit a snag with creating that release but working on it to get out of the way asap. 👍

sereeth commented 6 years ago

Yep same here, you have to use 105.2.3 or it blows up.

kmossco commented 6 years ago

The problem here is really that the new version of RestSharp has both assemblies: Net 4.5 and Net Standard 2.0. Our library currently only supports the Net 4.5 assembly for now.

kmossco commented 6 years ago

Closing this one for now as the problem is identified to be outside of the realm of this library, but please reopen if there's anything I can help with!