search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

Conversation model field "conversation_parts" is always null despite it shouldn't #113

Closed Fahrenheit9292 closed 6 years ago

Fahrenheit9292 commented 6 years ago

I have a problem regarding API conversation model: on your reference I could see this is the Object that contains conversation_parts Object Now when I try to get the Conversation object from JSON I always get the conversation_parts object with null value despite it has the value when using the Postman request conversation ID as example 15673691858 image that's how conversation_parts object does look like on Postman response image and on the project it's null

I know that on your SDK model conversation_parts field is not object, but List, however it didn't work as well.

kmossco commented 6 years ago

Thank you for reporting this. Just to be sure, can you please confirm which version of the SDK you are using? Is it 1.0.31 or are you already using the beta?

Fahrenheit9292 commented 6 years ago

Hey there, I'm using the 2.0 .NET SDK that is now available on GitHub.

Best regards, Andrey

On Thu, Apr 26, 2018 at 10:17 AM, Bruno Vieira notifications@github.com wrote:

Thank you for reporting this. Just to be sure, can you please confirm which version of the SDK you are using? Is it 1.0.31 or are you already using the beta?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/intercom/intercom-dotnet/issues/113#issuecomment-384538791, or mute the thread https://github.com/notifications/unsubscribe-auth/AkrOxeNOb-ZNydf3QeSm3VqBINCfqa2Hks5tsXSkgaJpZM4TX3i9 .

Fahrenheit9292 commented 6 years ago

Hey there, did you figure this out?

Fahrenheit9292 commented 6 years ago

2018-05-03_10-31-26 2018-05-03_10-32-42 I'm pretty sure the problem here is with JsonConverter used for the fields "tags" and "conversation_parts" on the "Conversation" Object

Fahrenheit9292 commented 6 years ago

as you can see, the tags field is null for the conversation on c# and not null on Postman response for the same conversation

kmossco commented 6 years ago

Hey @Fahrenheit9292, sorry for the delay but I think I got this resolved in PR #132. I am looking to merge it next week, but if you want to give it a try in the meantime let me know if you bump into any issues with it.