Closed ThomasArdal closed 6 years ago
You're right, this is missing. We are having a few woes with the transition to DotnetStandard but I'll try to squeeze this in asap.
However if anyone has the time to send us a PR I'll be happy to review it.
How would you prefer the include_count parameter to be set?
Could be always:
result = Get<Segment>(parameters: new Dictionary<string, string> { { "include_count", "true" } }, resource: SEGMENTS_RESOURCE + Path.DirectorySeparatorChar + id);
Through a parameter on the View-method:
public Segment View(String id, includeCount = false)
Or something third?
@kmossco
@ThomasArdal so sorry for the delay here, completely missed this one. 😞 I think that the second option would make more sense as it's the pattern we already have for other endpoints like Scroll:
How does that sound?
No problem :smile:
There you go: https://github.com/intercom/intercom-dotnet/pull/126
This is awesome! 🎉 Thank you so much. We are having a few issues with our Nuget package build and so PRs are a bit delayed, but as soon as we fix that I'll review your PR and add it to the next release. 👍
In the API, Segments have a
count
attribute. This attribute is never mapped to a property on theSegment
object. I've talked with Intercom support, who tell me that it is becausecount
wasn't available in the previous versions of the API.