intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

Please make client class disposable and call httpClient.Dispose() #134

Open slegay opened 6 years ago

slegay commented 6 years ago

The client class uses an instance of HttpClient, which implements IDisposable, but never disposes of it. I am not sure what the memory and networking consequences are when creating a bunch of HttpClient instances without proper disposal, but it might be a good idea to implement IDisposable and allow developers to properly release those resources.

kmossco commented 6 years ago

Thank you for this, we are right now prioritising adding feature parity to our API and then we will be working to actually move to asynchronously requests which may solve this problem at once. But happy to review any PR in the meantime if you have the time to create one. 👍