search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 54 forks source link

Make it available for .NET Framework 4.6.1 #137

Closed ogamaniuk closed 4 years ago

ogamaniuk commented 5 years ago

Can you please make a version for .NET Framework 4.6.1? Nobody's using .NET Standard.

wil55n commented 5 years ago

Yes please, we're having alot of issues using 2.x with .Net Framework projects.

jpasichnyk commented 5 years ago

I believe it should be built against both netstandard2.0 and net45 for compatibility with those moving over to .NET Core as well as those not.

CarloSaccone commented 5 years ago

I think that there should be 2 different packages for .net core and .net >4.5. Tried to nuget on an existing webapi .net 4.6.1 and it broke all the references in the project. Tried to clean it up and leaving just the reference to restsharp, but no luck.

jpasichnyk commented 5 years ago

I just created a pull request which multi-targets the SDK against both the existing "netstandard2.0" and as well as "net452" (which i believe should allow >= 4.5.2 to use it).

Intercom maintainer, please review/merge the pull request: https://github.com/intercom/intercom-dotnet/pull/147

lindeberg commented 5 years ago

Any progress?

lloydliyu commented 4 years ago

Hey @jpasichnyk :wave:

It looks like this was solved since https://github.com/intercom/intercom-dotnet/pull/147 was merged. If that isn't the case feel free to reopen this.